Add Reverse Swap notification #953
Conversation
dangeross
force-pushed
the
savage-reverse-swap-notification
branch
from
5166080
to
76b6cba
Compare
dangeross
force-pushed
the
savage-reverse-swap-notification
branch
2 times, most recently
from
ca76cfd
to
e63dc2c
Compare
dangeross
force-pushed
the
savage-reverse-swap-notification
branch
from
0108a93
to
68cec99
Compare
dangeross
force-pushed
the
savage-reverse-swap-notification
branch
from
68cec99
to
c88c64e
Compare
dangeross
force-pushed
the
savage-reverse-swap-notification
branch
from
c88c64e
to
0234597
Compare
| } | ||
|
|
||
| this.bitcoinAddress?.let {address -> |
There was a problem hiding this comment.
I think it would be nice to be able to recognize whether it is a swap or reverse swap without trying both.
If we pass a query param app_data in the webhook url it returns back in the notification payload.
See here where it is grapped from the query param: https://github.com/breez/notify/blob/main/http/router.go#L40
And here how it is populated into the payload: https://github.com/breez/notify/blob/main/breezsdk/init.go#L43
Perhaps we can use it here to identify if it is a swap or reverse swap?
There was a problem hiding this comment.
Yeah, I thought that too, but the redeemSwap first checks there is a swap for that address so it's pretty inexpensive.
What if the application or NDS is already using the app_data param in someway? We would override it and potentially break NDS/app logic.
There was a problem hiding this comment.
That's a good argument. I am ok then to leave this inexpensive check.
dangeross
force-pushed
the
savage-reverse-swap-notification
branch
from
ec1266c
to
fb13b8f
Compare
| @@ -194,20 +194,20 @@ class NotificationHelper { | |||
| group = LNURL_PAY_WORKGROUP_ID | |||
| } | |||
| val swapTxConfirmedNotificationChannel = NotificationChannel( | |||
There was a problem hiding this comment.
Should we rename the notification channel & notification channel group variable as well?
This PR adds background processing of the reverse swap flow using webhooks:
process_reverse_swapmethod to handle processing an individual reverse swap by addressFixes #924